Skip to content

test: mark SEA tests flaky on linux arm debug#63743

Open
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:test-build-sea
Open

test: mark SEA tests flaky on linux arm debug#63743
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:test-build-sea

Conversation

@trivikr

@trivikr trivikr commented Jun 4, 2026

Copy link
Copy Markdown
Member

The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky only
on linux arm debug, matching the node-test-commit-arm-debug job
where the flakes have been observed.

Refs:

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 4, 2026
@trivikr trivikr added flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 4, 2026
Comment thread test/sea/sea.status
The LIEF-based --build-sea tests can be killed by the OS on the
linux arm debug CI worker while rebuilding the ELF binary. The failures
all happen after SEA serialization succeeds, when the injector enters
LIEF::ELF::Builder::build(), and report SIGKILL instead of a test
assertion failure.

Mark the affected SEA build and application test families as flaky only
on linux arm debug, matching the node-test-commit-arm-debug job where
the flakes have been observed.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@trivikr trivikr changed the title test: mark SEA tests flaky on linux arm test: mark SEA tests flaky on linux arm debug Jun 5, 2026
@trivikr trivikr requested a review from joyeecheung June 5, 2026 04:36
@trivikr trivikr added review wanted PRs that need reviews. and removed review wanted PRs that need reviews. labels Jun 6, 2026
Comment thread test/sea/sea.status Outdated

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2026
@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2026
@trivikr

trivikr commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

The request-ci is not starting since it needs approval from someone other the last pusher.
I've re-requested approval from @joyeecheung

@trivikr trivikr requested a review from joyeecheung June 8, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants